[Dialog] Remove `disableEscapeKeyDown` prop, in favor of using the `onClose` callback

[nzayatz14]

Is there any particular reason that the disableBackdropClick prop is deprecated on the Dialog component but the disableEscapeKeyDown prop is not?

I feel like they should either both be deprecated and handled the same way via the handleClose function, or neither should be deprecated.

Docs (v4.12.1) are currently showing:

[michal-perlakowski]

From the pull request that removed disableBackdropClick:

disableEscapeKeyDown is on the chopping block as well but will be handed separately.

[nzayatz14]

Ok sounds good, just wanted to make sure things were remaining consistent

[mnajdova]

We will probably need to move this to v6. The reason is that the property still exists in v5, and we wouldn't like to introduce more braking changes now that we are in beta. Thanks for the report @nzayatz14

[eps1lon]

This is fine for v5. Otherwise the API just looks weird as mentioned in the issue description. I just forgot to do it.

[eps1lon]

On the other hand, Modal also does stop event propagation which is a bit scary to change. Let's do this in v6.

[oliviertassinari]

Is there any particular reason that the disableBackdropClick prop is deprecated on the Dialog component but the disableEscapeKeyDown prop is not?

@nzayatz14 Yes. It's similar to the other events but not identical. The motivation to keep it was to kill two birds (not call on click + call event.stopPropagation()) in one stone (disableEscapeKeyDown). It's meant as a helper with a pit of success. If we remove it, developers would have to not forget to call event.stopPropagation(), they will get bad surprises otherwise.