Turn deprecation warnings into logs

[fzaninotto]

Deprecation warnings in the latest 3.x versions make my app look like it's broken, while it works perfectly. I know that these warnings only appear in development, however they bring a lot of noise and potentially hide real errors.

Is it possible to turn these warnings into console.log() messages instead of console.error()?

• This is not a v0.x issue.
• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Use code from 3.0 with the latest 3.x without error (because of semver)

Current Behavior 😯

Using an old Typography variant (like <Typography variant="title" />), or a <TableCell numeric />, or a raised Button raises error in the console:

Context 🔦

I'm migrating react-admin from material-ui v1 to material-ui v3 (cf marmelab/react-admin#3102). And I can't find a syntax that works for both versions :(

[oliviertassinari]

@fzaninotto This is a prop-type warning. We try to follow the convention. I would encourage you to move the discussion to the prop-types repository: https://github.com/facebook/prop-types/blob/e32c4900f5ab5fd3acea93e9d2f0d09e4a2f2ceb/checkPropTypes.js#L20.

[oliviertassinari]

There is no syntax that works with both versions. The simplest is probably to jump from v1 to v4.

[oliviertassinari]

By the way, if you want to comment on https://spectrum.chat/material-ui/general/what-do-you-guys-think-about-the-tables-and-how-they-are-handled-in-material-ui~27c0b5be-9cea-4e8f-88bc-faaf4103bf33. It would be appreciated.

[fzaninotto]

Allow me me disagree.

If I made a mistake with a proptype, I find it normal that the console shows an error - it's my mistake.
If I wrote code with material ui v3 and it works without error, I find it normal that the console shows no error when I upgrade to a minor release.

The current behavior is really misleading: the console shows error while the code works perfectly and will continue to work fine in all 3.0 releases. That's a break of the semver semantics.

This is a prop-type warning. We try to follow the convention.

There is no standard for deprecation warnings that I know of. You chose to use PropTypes for these, but it's an implementation detail.

The simplest is probably to jump from v1 to v4.

No, because V1 and V3 are almost compatible (except for Firefox), while you're still busy adding instructions to the V4 upgrade guide.

[oliviertassinari]

There is no standard for deprecation warnings that I know of. You chose to use PropTypes for these, but it's an implementation detail.

@fzaninotto I hope we can use React.warn in v5 for this problem. React will introduce a new method that shows the stack trace when warning: facebook/react#15170.

[oliviertassinari]

Maybe you can upgrade to a v3 version that doesn't have the deprecation warnings?

[oliviertassinari]

Is it possible to turn these warnings into console.log() messages instead of console.error()?

We might want to use console.warn. console.log is too weak.

[oliviertassinari]

The most important constraint we have considered when adding the deprecation warning was to show the component stack trace. The only option we had was the prop-types warning, that happens to use console.error. I think that console.warn would be better here. (We were using the same strategy in v0.x).

[fzaninotto]

Maybe you can upgrade to a v3 version that doesn't have the deprecation warnings?

That's a good idea, but:

1. Which version is it?
2. It's not me who is going to upgrade to v3, it's the react-admin user base. I find it hard to explain them that react-admin supports v3.a but not v3.b because there are some breaking changes, while you say that you support semver...

I understand that you're deeply involved in v4 and that v3 might not be a priority for you, but I insist that this is a BC break.

Would it help if I submitted a PR to master?

[oliviertassinari]

@fzaninotto What about upgrading to v3, accepting v1 in the dependency range but fixing all the deprecation warnings in react-admin? I don't see the problem with react-admin introducing deprecation warnings to the users in a minor version bump.

[fzaninotto]

How can I fix the deprecations warnings? The code would stop working on V1.

[fzaninotto]

I don't see the problem with react-admin introducing deprecation warnings to the users in a minor version bump.

I agree if these are warnings. But your deprecation warnings are actually console errors.

[oliviertassinari]

Correct. This stratategy can't work. It's not backward compatible. What you need is an option to disable the deprecation warnings. console.log would probably still be too noisy.