[docs] Rename "docs-base" path alias to "docs" #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
michaldudak
previously approved these changes
Oct 17, 2024
michaldudak
reviewed
Oct 17, 2024
docs/scripts/formattedTSDemos.js
Outdated
| @@ -88,7 +88,9 @@ async function transpileFile(tsxPath, project) { | |||
| if (enableJSXPreview) { | |||
| transformOptions.plugins = transformOptions.plugins.concat([ | |||
| [ | |||
| require.resolve('docs/src/modules/utils/babel-plugin-jsx-preview'), | |||
| require.resolve( | |||
| 'node_modules/@mui/monorepo/docs/src/modules/utils/babel-plugin-jsx-preview', | |||
There was a problem hiding this comment.
This should work as well:
Suggested change
| 'node_modules/@mui/monorepo/docs/src/modules/utils/babel-plugin-jsx-preview', | |
| '@mui/monorepo/docs/src/modules/utils/babel-plugin-jsx-preview', |
There was a problem hiding this comment.
Yep that works, thanks!
vladmoroz
commented
Oct 17, 2024
docs/scripts/formattedTSDemos.js
Outdated
Comment on lines
91
to
93
| require.resolve('docs/src/modules/utils/babel-plugin-jsx-preview'), | ||
| require.resolve( | ||
| 'node_modules/@mui/monorepo/docs/src/modules/utils/babel-plugin-jsx-preview', | ||
| ), |
There was a problem hiding this comment.
So this was the only place where the monorepo docs package was referenced
I am not even sure we want to display the JS demos, but for now I think this is fine
michaldudak
approved these changes
Oct 17, 2024
vladmoroz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.