[Dialog] Fix Maximum update depth exceeded error with Suspense#3700
Merged
michaldudak merged 4 commits intomui:masterfrom Jan 8, 2026
Merged
[Dialog] Fix Maximum update depth exceeded error with Suspense#3700michaldudak merged 4 commits intomui:masterfrom
Maximum update depth exceeded error with Suspense#3700michaldudak merged 4 commits intomui:masterfrom
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaldudak
added
type: bug
michaldudak
force-pushed
the
fix-dialog-portal-suspense
branch
from
78ae150 to
3a07365
Compare
michaldudak
force-pushed
the
fix-dialog-portal-suspense
branch
from
3a07365 to
6933775
Compare
mj12albert
approved these changes
Jan 8, 2026
Member
mj12albert
left a comment
mj12albert
left a comment
There was a problem hiding this comment.
It fixes the issue in the repro: https://codesandbox.io/p/sandbox/base-ui-dialog-suspense-forked-4gnszf
But the new tests need to be skipped for React 18:
Member
Author
|
I actually updated the test to use |
michaldudak
changed the title
Maximum update depth exceeded error with Suspense
1 task
atomiks
pushed a commit
to atomiks/base-ui
that referenced
this pull request
Jan 14, 2026
|
Thank you so much, this was killing me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the portal node ref handling in FloatingPortal to avoid state updates during ref cleanup, which prevents the Suspense hide/show loop while still clearing the portal node via container changes.
Also added a missing
openstate getter in DialogPortal.Fixes #3695