Skip to content

[toggle group] More permissive towards falsy toggle values #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mj12albert merged 3 commits into from
Dec 11, 2025
Merged

[toggle group] More permissive towards falsy toggle values #3477

mj12albert merged 3 commits into from
Dec 11, 2025
+55 −5

Conversation

@mj12albert
Copy link
Member

@mj12albert mj12albert commented Dec 9, 2025 •
edited
Loading

Generate a default value for toggles inside a toggle group if the value is missing or falsy so it's still usable.

Closes #3465

@mj12albert mj12albert added component: toggle group Changes related to the toggle group component. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Dec 9, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025 •
edited
Loading

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3477

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3477

commit: 94737e6

@mui-bot
Copy link

mui-bot commented Dec 9, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+8B(0.00%) 0B(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 9, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 94737e6
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/693a3bddce928f0008bea145
😎 Deploy Preview https://deploy-preview-3477--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mj12albert mj12albert marked this pull request as ready for review December 9, 2025 14:55
@mj12albert mj12albert added type: bug It doesn't behave as expected. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Dec 9, 2025
atomiks
atomiks reviewed Dec 9, 2025
View reviewed changes
LukasTy
LukasTy approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. 👍

mj12albert and others added 2 commits December 11, 2025 11:34
@mj12albert @LukasTy
Update packages/react/src/toggle/Toggle.tsx
277ff53 
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Albert Yu <albert@albertyu.co>
@mj12albert
Merge branch 'master' into fix/toggle-group-omit-value
94737e6
@mj12albert mj12albert merged commit 4430bb7 into mui:master Dec 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atomiks atomiks atomiks left review comments

@LukasTy LukasTy LukasTy approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

component: toggle group Changes related to the toggle group component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[toggle] Internal pressed check only happens if the value is truthy

4 participants

@mj12albert @mui-bot @LukasTy @atomiks