[menu] Add <Menu.Link> part
#3400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: menu
mj12albert
force-pushed
the
menu-item-link
branch
from
dd405c8 to
5b39504
Compare
commit: |
1 task
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Member
Author
|
Or this could just be |
mj12albert
force-pushed
the
menu-item-link
branch
from
5b39504 to
ee02677
Compare
mj12albert
removed
the
breaking change
LukasTy
reviewed
Dec 4, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Nice work. 👍
Am I missing something? Or does this component really is missing the menuitem prop?
Screen reader behavior in the experiment example is not optimal. 🙈
Comment on lines
9
to
15
| const { render, clock } = createRenderer({ | ||
| clockOptions: { | ||
| shouldAdvanceTime: true, | ||
| }, | ||
| }); | ||
|
|
||
| clock.withFakeTimers(); |
Member
There was a problem hiding this comment.
Nitpick: Doesn't look like clock faking is needed. 🤔
Suggested change
| const { render, clock } = createRenderer({ | |
| clockOptions: { | |
| shouldAdvanceTime: true, | |
| }, | |
| }); | |
| clock.withFakeTimers(); | |
| const { render } = createRenderer(); |
mj12albert
force-pushed
the
menu-item-link
branch
from
8621e8f to
6366c8f
Compare
mj12albert
force-pushed
the
menu-item-link
branch
from
6366c8f to
7da6bb0
Compare
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for
<MenuItem render={<a href="#" />}Preview: https://deploy-preview-3400--base-ui.netlify.app/experiments/menu/menu-fully-featured