[core] Fix render prop types #1213
Conversation
atomiks
added
core
Netlify deploy preview |
| @@ -46,14 +46,18 @@ namespace TooltipTrigger { | |||
| open: boolean; | |||
| } | |||
|
|
|||
| export interface Props extends BaseUIComponentProps<any, State> {} | |||
| export interface Props extends BaseUIComponentProps<'div', State> {} | |||
There was a problem hiding this comment.
Do we expect here people to always need to cast if they use different element?
There was a problem hiding this comment.
The render prop's props parameter is actually loosely typed in order to allow you to compose different tags.
We need to ensure we document when a tag can't be replaced if we aren't polyfilling native behavior (e.g. if it relies in a specific tag's native props in order to work, like <button> being replaced with a <span>, but internally is not using useButton() to keep it accessible).
We could actually remove the first tag type since it serves no purpose in this case
There was a problem hiding this comment.
Let's see if this will be enough, if we see more issues around this we can revisit it.
Continues #1209
Switches to
GenericHTMLPropsfor therenderprops type. This includes therefwhich was previously missing. Using'div'for Tooltip uses theGenericHTMLPropsregardless.