Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Issue but an inquiry and question (loops, auto, 24/7) #24

Closed
MelodicCrypter opened this issue Feb 18, 2021 · 17 comments
Closed

Not Issue but an inquiry and question (loops, auto, 24/7) #24

MelodicCrypter opened this issue Feb 18, 2021 · 17 comments
Labels
enhancement New feature or request

Comments

@MelodicCrypter
Copy link
Contributor

Hi @neolao , great job on this!

I just want to ask if it is possible to loop this one? Coz my client wants me to develop like that of SpriteClub where we can do some internal betting. I'm planning to use your repo. If some of the features are not yet available, I will try fork this one. But much better if you can implement it since for sure you know the ins and outs of the codebase.

So the flow would be:

  • After I click the quick-versus.exe, it will automatically and randomly select from available characters
  • then automatically and randomly select stage
  • then after selecting characters and stage, it will pause for about 1 minute, to let the user bet (I will take care of this on another server, frontend)
  • then a minute fire up the mugen.exe
  • then record the match result (this is already done, Arxos from SpriteClub has a mugenwatcher for this one)
  • then after match, it will loop again from the beginning, auto select characters, stage, then so on.

Goal is like a 24/7 match. I hope to hear your reply on this one. Thanks!

@neolao
Copy link
Member

neolao commented Feb 18, 2021

Hello, I'm glad you like it.

I don't really want to deviate from the purpose of the application. But, some of your ideas are not contrary.

After I click the quick-versus.exe, it will automatically and randomly select from available characters

It reminds me the "watch mode" in MUGEN. I think it can be interesting to do that.

then after selecting characters and stage, it will pause for about 1 minute, to let the user bet (I will take care of this on another server, frontend)

This feature is specific of your needs. But, it can be cool in the "watch mode" to see the screen with 2 characters before the match. And a simple configuration for the count down.

then after match, it will loop again from the beginning, auto select characters, stage, then so on.

In the "watch mode", the loop is ok.

So, I'm ok to include a "watch mode" in the application. I think of some new properties in the configuration file.

You can also fork the repository and create merge requests. We can discuss about how to implement it together if you are in a hurry. I will try to do the "watch mode" in my free time.

@neolao neolao added the enhancement New feature or request label Feb 18, 2021
@MelodicCrypter
Copy link
Contributor Author

@neolao thanks, yes, that would be awesome (watch mode)! I will just wait first for your feature/enhance then let's see from there, how to add the "waiting screen" enhancement. Thanks so much!

@neolao
Copy link
Member

neolao commented Feb 18, 2021

The more I think about it and the more I believe it's better to create a dedicated application to launch a random fight.

The only added value by creating an application is the "waiting screen", because a random fight is easy scriptable.

@MelodicCrypter
Copy link
Contributor Author

I see. So, you can just easily implement the 'watch mode'/'random'. Maybe you can add it this week during free time?

@neolao
Copy link
Member

neolao commented Feb 19, 2021

The random part and executing mugen.exe is easy, you don't even need to create an application, just a simple script.

I created a project here: https://github.com/mugen-launcher/watch-mode

My free time is not regular, so I don't know when it will be done.

@MelodicCrypter
Copy link
Contributor Author

Thanks! I will try this out.

@neolao
Copy link
Member

neolao commented Feb 19, 2021

I manage to create a quick build, it seems to work. Can you try it?

I hardcoded the waiting screen duration (5 seconds), just for the test.

I need to do some cleaning (it is a PoC), refactor some things and write the documentation.

@MelodicCrypter
Copy link
Contributor Author

I will try to build for windows and run on windows mugen... awesome work...

@MelodicCrypter
Copy link
Contributor Author

@neolao overall nice...

Results on my side:

  • the window is stuck at "Loading", after showing the VS screen (after 5 seconds) the mugen.exe won't fire up.
  • same characters were chosen, let's add a code line where if index are the same it will randomize again
  • by the way, is the stage already randomized?

Thanks a lot for this

@neolao
Copy link
Member

neolao commented Feb 19, 2021

Yes, I didn't randomize the stage yet.

Ok, I need to take more time on it. But I don't think we are far from the expected result.

@MelodicCrypter
Copy link
Contributor Author

@neolao , the error was "cannot read property 'pause' of undefined', it's in the app.js file

@neolao
Copy link
Member

neolao commented Feb 19, 2021

I fixed this sound issue

@neolao
Copy link
Member

neolao commented Feb 19, 2021

added:

  • random stage
  • configurable waiting screen duration with the parameter "waitingScreenDuration" in milliseconds
  • always different characters

@MelodicCrypter
Copy link
Contributor Author

Nice nice, I will try this. Thanks a lot!

@MelodicCrypter
Copy link
Contributor Author

By the way, are the characters and stages, really applicable to mugen or I should download real characters and stages?

For example, if I will add a new stage, I will download the stage first, then create an image preview of it, then add to our configs, then manually add that stage also to the select.def file inside data/select, is that correct?

@neolao
Copy link
Member

neolao commented Feb 19, 2021

Yes, it's based on the same configuration file for the moment. I just copy paste some codes.
But you don't need to edit the select.def from Mugen.

@neolao
Copy link
Member

neolao commented Feb 19, 2021

I uploaded a working version (for me): https://github.com/mugen-launcher/watch-mode/releases/tag/0.0.2

Can you use the other project to suggest improvements and bugs?

I added:

  • default to 1 round, configuration "roundCount"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants