Fix go-lint violations in cfg package
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
Oct 5, 2020
cfg/config_test.go
Outdated
| @@ -9,15 +9,17 @@ import ( | |||
| func TestNew(t *testing.T) { | |||
| conf, err := New("/foobar") | |||
| if err != nil { | |||
| panic(err) | |||
| t.Error("cannot create config from path") | |||
There was a problem hiding this comment.
Couldn't we just use t.Fatal here?
There was a problem hiding this comment.
Thank you! I'm a bit lost without assertify 🙃 Fixed
cfg/config_test.go
Outdated
| @@ -26,24 +28,28 @@ func TestNew(t *testing.T) { | |||
| cwd, _ := os.Getwd() | |||
| p := filepath.Join(cwd, "testdata/beehive-crypto.conf") | |||
| conf, err = New(p) | |||
| if err != nil { | |||
| panic(err) | |||
There was a problem hiding this comment.
Great catch! Fixed.
|
Review comments are applied 👍 |
|
Thank you @orsinium, loving all the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run
golangci-lintoncfgpackage and it found some violations. Mostly, it comes fromgo-lintand about ignored variables and unchecked errors.The PR fixes all the violations.