Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade documentation for the cron and timer hives #293

Open
Zykino opened this issue Apr 13, 2020 · 4 comments
Open

Upgrade documentation for the cron and timer hives #293

Zykino opened this issue Apr 13, 2020 · 4 comments

Comments

@Zykino
Copy link

Zykino commented Apr 13, 2020

I just saw there are Cron and Time hives and they look too be identical.
The descriptions should better state that Cron is recurring and Time one time only ? The Time hive may need a "once" or "one time only" in the description to make the difference really clear.

And if possible they should be near (Time once, Time recurring (cron)) so user will see both at once and choose whichever they need.

@rubiojr
Copy link
Collaborator

rubiojr commented Apr 14, 2020

👍 The intention of both hives hasn't been clear to me either. I've been thinking we had two different implementations that did the same thing for a while.

@rubiojr
Copy link
Collaborator

rubiojr commented Apr 14, 2020

@muesli, would it help to rename that hive to "Once", "On This Date" or something like that?

@Zykino
Copy link
Author

Zykino commented Apr 14, 2020

I heard you are reworking the admin interface (potentially adding categories) but I think that it is quite important that since this two hives are so close (utility, logo, input, descriptions) that they need to share part of the name and be differentiated on an other part. That way they will be next to each other in the list and as a user I will ask myself which one I need right now. Except if you intent to randomize the hives order…

Something like:
Time (Once)
Time (Recurrent)

@muesli
Copy link
Owner

muesli commented Apr 16, 2020

I agree, we should clean that up and combine those two Hives into one, which then offers multiple event types.

We should probably also drop the underlying cron library and switch to a maintained and better tested one: https://github.com/robfig/cron

rubiojr added a commit that referenced this issue Jul 24, 2020
rubiojr added a commit that referenced this issue Jul 24, 2020
Handles parsing better, supporting the cron spec.

Partially addresses #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants