Added global settings to plugin #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix to issues mudrd8mz#16 and mudrd8mz#17. I added a setting possibility to decide if the titles should be forced to use or not (then the summary would be taken if the default title is set and the summary is not empty). This should fix issue mudrd8mz#17 And then I added a settings.php to enable global settings. There the admin can set the default value and is able to lock the settings so that teachers cannot change value anymore. This setting simply will not be presented to the teacher in the individual block settings. This should fix and extent issue mudrd8mz#16.
|
Thanks a lot for submitting this pull request. I have it in my TODO inbox and I'll try to get to it as soon as possible. Thanks for understanding. |
|
Hi @Kathrin84 can you please config you have received my feedback on the patch? |
|
Hi David, I received your feedback, however did not found time to deal with them yet. Sorry for that. |
|
Hi David, I'm back from holidays. I saw that you released a new version that fixes the issue with the standard headings and summary usage. For me, your improvement looks very fine in usage. Cheers, Kathrin |
|
Thanks for the confirmation Kathrin. I am closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making this pull request on behalf of Alexander Bias.
This is a fix to issues #16 and #17.
I added a setting possibility to decide if the titles should be forced
to use or not (then the summary would be taken if the default title is
set and the summary is not empty). This should fix issue #17
And then I added a settings.php to enable global settings. There the
admin can set the default value and is able to lock the settings so
that teachers cannot change value anymore. This setting simply will not
be presented to the teacher in the individual block settings. This
should fix and extent issue #16.
Concerning the strings: I tried my best with it. If you have a better idea for naming or description texts, feel free to change them.