Skip to content

Remove lib/simple_html_dom.php #28

Closed
@tmuras

Description

@tmuras

Hello,

It looks like external library simple_html_dom.php is used only in one place:

private function extract_title($summary)

I think we don't really need it - and can use PHP's functions. What do you think about removing this dependency?
The library seems dated and it's not fully functional - ie this won't load HTTPS:

    function __construct($str=null) {
        if ($str) {
            if (preg_match("/^http:\/\//i",$str) || is_file($str)) 
                $this->load_file($str); 
            else
                $this->load($str);
        }
    }

But it's not a problem here as it' used in your code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions