Skip to content

Allow repo add to set authentication for private repository #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 1 commit into from
Dec 17, 2024
Merged

Allow repo add to set authentication for private repository #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions cmd/repo/add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ Adds a repository to the system. URLs, local files or inline repo can be specifi

luet repo add ... --name "foo"

# Inline:
# Inline (provided you have $PASSWORD environent variable set):

luet repo add testfo --description "Bar" --url "FOZZ" --type "ff"
luet repo add testfo --description "Bar" --url "FOZZ" --type "ff" --username "user" --passwd $(echo "$PASSWORD")

`,
Run: func(cmd *cobra.Command, args []string) {
Expand All @@ -61,6 +61,8 @@ Adds a repository to the system. URLs, local files or inline repo can be specifi
url, _ := cmd.Flags().GetString("url")
ref, _ := cmd.Flags().GetString("reference")
prio, _ := cmd.Flags().GetInt("priority")
username, _ := cmd.Flags().GetString("username")
passwd, _ := cmd.Flags().GetString("passwd")

if len(util.DefaultContext.Config.RepositoriesConfDir) == 0 && d == "" {
util.DefaultContext.Fatal("No repository dirs defined")
Expand All @@ -82,6 +84,10 @@ Adds a repository to the system. URLs, local files or inline repo can be specifi
Type: t,
Urls: []string{url},
Priority: prio,
Authentication: map[string]string{
"username": username,
"password": passwd,
},
}
} else {
r, err = types.LoadRepository([]byte(str))
Expand All @@ -103,6 +109,12 @@ Adds a repository to the system. URLs, local files or inline repo can be specifi
if prio != 0 {
r.Priority = prio
}
if username != "" && passwd != "" {
r.Authentication = map[string]string{
"username": username,
"password": passwd,
}
}
}

file := filepath.Join(util.DefaultContext.Config.System.Rootfs, d, fmt.Sprintf("%s.yaml", r.Name))
Expand Down Expand Up @@ -133,5 +145,7 @@ Adds a repository to the system. URLs, local files or inline repo can be specifi
cmd.Flags().String("url", "", "Repository URL")
cmd.Flags().String("reference", "", "Repository Reference ID")
cmd.Flags().IntP("priority", "p", 99, "repository prio")
cmd.Flags().String("username", "", "repository username")
cmd.Flags().String("passwd", "", "repository password")
return cmd
}