Avoid exception if files .dockerinit / .dockerenv aren't present #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geaaru
force-pushed
the
fix-clean-docker-files
branch
2 times, most recently
from
3557976 to
6058310
Compare
mudler
requested changes
Nov 11, 2017
|
|
||
| err = os.Remove(dirname + SEPARATOR + ".dockerinit") | ||
| if err != nil { | ||
| if fatal == true { |
There was a problem hiding this comment.
+1 for checking before removing, but i would still keep the fatal flag usage
geaaru
force-pushed
the
fix-clean-docker-files
branch
from
6058310 to
bd1bb75
Compare
mudler
approved these changes
Nov 11, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files .dockerinit/.dockerenv aren't deprecated [https://github.com/moby/moby/issues/18355]