fix: prevent interactive commands from stalling MCP shell#22
Merged
mudler merged 3 commits intomudler:masterfrom Mar 3, 2026
Merged
Conversation
- Add process group management for proper child process cleanup - Add detectInteractiveCommands function to warn about potentially interactive commands - Add process group kill on timeout to ensure all child processes are terminated Fixes: mudler#20
Contributor
Author
|
✅ Fixed CI build failure - removed unused |
mudler
approved these changes
Mar 3, 2026
mudler
reviewed
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #20 - Interactive commands causing MCP shell to stall indefinitely.
Changes
Testing
The fix ensures that:
Fixes: #20