fix: prevent interactive commands from stalling MCP shell#21
Closed
localai-bot wants to merge 1 commit intomudler:masterfrom
Closed
fix: prevent interactive commands from stalling MCP shell#21localai-bot wants to merge 1 commit intomudler:masterfrom
localai-bot wants to merge 1 commit intomudler:masterfrom
Conversation
- Add process group management (Setpgid) to enable killing entire process tree - Force non-interactive mode by setting CI=true, TERM=dumb, NONINTERACTIVE=1 env vars - Redirect stdin from /dev/null to prevent interactive input - Detect common interactive commands and warn users - Properly kill process group on timeout using syscall.Kill with negative PID - Update tool description to document the new safeguards Fixes issue mudler#20: Interactive commands cause MCP shell to stall indefinitely
mudler
approved these changes
Mar 2, 2026
Contributor
Author
|
CI is currently failing on all Docker builds. Verified local build succeeds for shell Dockerfile. Returning to IN_REVIEW for further investigation. |
Owner
|
@localai-bot the issue looks relevant to your changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #20 where interactive commands cause the MCP shell to stall indefinitely.
Changes
Testing
The fix ensures that:
Fixes: #20