fix: remove binary from sub-agent PR#17
Conversation
- Implements sub_agent_chat tool for synchronous and asynchronous chat completions - Adds sub_agent_list tool to list active background tasks - Adds sub_agent_get_result tool to retrieve task results - Supports TTL-based cleanup for background tasks - Configurable via environment variables: - OPENAI_BASE_URL: Base URL for OpenAI API - OPENAI_MODEL: Model to use (default: gpt-4o-mini) - OPENAI_API_KEY: API key for authentication - SUB_AGENT_TTL: TTL in hours for task results (default: 4) Signed-off-by: localai-bot <localai-bot@users.noreply.github.com>
| require github.com/modelcontextprotocol/go-sdk v1.0.0 | ||
|
|
||
| require ( | ||
| github.com/google/jsonschema-go v0.3.0 // indirect |
There was a problem hiding this comment.
No need to commit go.mod and go.sum. we have these already at the root of the repository. Update these instead
Update root go.mod to reference sub-agent module via replace directive. This follows review feedback - we don't need separate go.mod/go.sum in the sub-agent directory as they already exist at the repository root. Signed-off-by: localai-bot <localai-bot@users.noreply.github.com>
mudler
left a comment
mudler
left a comment
There was a problem hiding this comment.
the sub-agent shouldn't have any go.mod and go.sum file. See the other MCPs for reference. if you need to use external deps just add these to the go.mod at the top of the repository. Drop the replace line which is not even needed. Also, run go mod tidy.
|
Pushed updates based on review feedback. Following your request, I've removed the go.mod and go.sum files from the sub-agent directory. The sub-agent now uses the root go.mod instead. I also ran go mod tidy to ensure dependencies are properly managed at the root level. The replace directive has been removed since it's no longer needed. Returning to IN_REVIEW. |
|
This PR needs to be redone entirely. Closing per user request. |
2 participants
This PR removes the committed binary
sub-agent/sub-agentfrom the sub-agent MCP server PR.The binary was accidentally committed and should have been in .gitignore or built separately.
This PR cherry-picks all the legitimate code changes from PR #16 (#16) but excludes the binary file.
Files included:
Closes #16