fix(uri): consider subfolders when expanding huggingface URLs #7634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mintyleaf <mintyleafdev@gmail.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
good catch. this was an oversight, just as a note you don't need to specify the GGUF file even if it's in a subfolder. During the import process you should be able to just specify |
mudler
changed the title
mudler
reviewed
Dec 18, 2025
|
|
||
| branch := "main" | ||
| filepath := repoPieces[2] | ||
| filepath := strings.Join(repoPieces[2:], "/") |
Owner
There was a problem hiding this comment.
would be great if we could cover this in our unit tests in pkg/downloader/uri_test.go
sredman
pushed a commit
to sredman/LocalAI
that referenced
this pull request
Dec 20, 2025
…#7634) Update uri.go Signed-off-by: mintyleaf <mintyleafdev@gmail.com> Signed-off-by: Simon Redman <simon@ergotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR possibly fixes an inability to download file in subfolder from huggingface
for example to download that model i was forced to use https:// prefix instead of huggingface://
https://huggingface.co/huihui-ai/Huihui-gpt-oss-20b-BF16-abliterated-v2/blob/main/GGUF/Huihui-gpt-oss-20b-BF16-abliterated-v2-Q4_K_M.ggufthe
huggingface://huihui-ai/Huihui-gpt-oss-20b-BF16-abliterated-v2/GGUF/Huihui-gpt-oss-20b-BF16-abliterated-v2-Q4_K_M.ggufis invalid, and localai tries to download file namedGGUFand gets 404is that done on purpose, or just overlooked?