-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(stablediffusion): Passthrough more parameters to support z-image and flux2 #7419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The stablediffusion CLI seems to work fine every time. It initializes some structures itself instead of using the library functions e.g I noticed somethign very strange when sending two requests in serial (which segfaults it) before the model generation for the second request is done it says "gen_image is done" and gives the image name for the previous generation. This image doesn't actually appear to get saved to disk. EDIT: this just appears to be due to a missing newline and some changes to the directory structure, so it's looking more like the usage of SD is wrong. |
… and flux2 Signed-off-by: Richard Palethorpe <io@richiejp.com>
Signed-off-by: Richard Palethorpe <io@richiejp.com>
… PNG Signed-off-by: Richard Palethorpe <io@richiejp.com>
342c4e1 to
0d1949a
Compare
Signed-off-by: Richard Palethorpe <io@richiejp.com>
|
So there are a few defaults we did different and we are using strings allocated by Go which would explain the segfaults on the second try because the pointers stored in the ctx object could have been reclaimed by then. |
Signed-off-by: Richard Palethorpe <io@richiejp.com>
4c1fb40 to
0072697
Compare
|
It appears I have stopped the segfaults by also setting free_params_immediately to false which defaults to true. Stil getting black images randomly. |
17f33cb to
0f2fe71
Compare
Signed-off-by: Richard Palethorpe <io@richiejp.com>
0f2fe71 to
e444e4f
Compare
|
I've exhausted every possibility I can think of for why I'm getting a black box randomly. I can't see any parameter that is different or see how the Go/CPP memory interface could be causing it. I've never seen it on the upstream CLI, but I'm wondering if this could be an Intel related issue and would be good to have someone test it on another system @mudler |
|
Interesting.. also I don't see anything from a quick scan. let's merge it so can have better testing overall |
|
Probably the black image is related to this: leejet/stable-diffusion.cpp#1031, strange though that I only get it in LocalAI and not in the upstream CLI. |
|
I've tested this with NVIDIA and did not experience this issue. All I can think is that it is an upstream issue that is highly sensitive to environmental inputs and will require some more indepth debugging to figure out. |

Redo #7414
Related: #7399
TODO:
Test Flux 2(uses Mistral 24b == I can't be bothered)Previously Z-Image ran out of VRAM, but I have 16GB and it should be using 4bit quants