Skip to content

feat(whisper): Enable SYCL #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

Conversation

richiejp
Copy link
Collaborator

@richiejp richiejp commented Jul 6, 2025

Signed-off-by: Richard Palethorpe io@richiejp.com

Description

This enables Whisper's SYCL support

Notes for Reviewers

The linker flags added for the benefit of CGO could be overkill, but it is a real pain finding the exact minimum set of flags. For some reason it is quite different from stablediffusion even though the both use the GGML SYCL support.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jul 6, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 2e9afc5
🔍 Latest deploy log https://app.netlify.com/projects/localai/deploys/686bb936ee4e1e0008c38303
😎 Deploy Preview https://deploy-preview-5802--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@richiejp richiejp marked this pull request as ready for review July 7, 2025 07:41
@richiejp richiejp force-pushed the feat/whisper/enable-sycl branch from 624692b to c419858 Compare July 7, 2025 07:42
Signed-off-by: Richard Palethorpe <io@richiejp.com>
@richiejp richiejp force-pushed the feat/whisper/enable-sycl branch from c419858 to 2e9afc5 Compare July 7, 2025 12:10
@richiejp
Copy link
Collaborator Author

richiejp commented Jul 7, 2025

For some reason -fopenmp is being passed to CGO on OSX which it doesn't support.

@richiejp
Copy link
Collaborator Author

richiejp commented Jul 7, 2025

Avoiding setting CC="" fixed it. 🤷

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @richiejp , good catch! Looking forward also to isolate many of these settings per-backend and offload logic from the main Makefile. But this is slowly coming as we untangle the embedded backends (see e.g. #5790)

@mudler mudler merged commit c1dd4ff into mudler:master Jul 8, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants