Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown links ending with ")" are not correctly converted #74

Closed
oupala opened this issue Apr 15, 2016 · 5 comments
Closed

markdown links ending with ")" are not correctly converted #74

oupala opened this issue Apr 15, 2016 · 5 comments

Comments

@oupala
Copy link

oupala commented Apr 15, 2016

markdown links ending with ")" are not correctly converted.

Such links are often encountered in wikipedia.

The bug comes from marked (markedjs/marked#619) and it appears that it won't be fixed.

It's maybe time to switch the markdown renderer... (see #73).

@mudassir0909
Copy link
Owner

can you make that change if you are free, I'll be busy for couple more weeks. It's just switching the npm library that we use & modify a single line here

@oupala
Copy link
Author

oupala commented May 3, 2016

I tried to replace marked by markdown-it but generating the resume fails due to the absence of the marked module, I must have missed some build step:

module.js:440
    throw err;
    ^

Error: Cannot find module 'marked'

Please help me with some more information so I can test markdown-it.

@mudassir0909
Copy link
Owner

can you commit your changes so that I can see what's going wrong?

mudassir0909 added a commit that referenced this issue May 3, 2016
@mudassir0909
Copy link
Owner

Made the changes :)

@oupala
Copy link
Author

oupala commented May 4, 2016

It works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants