For Review - don't merge #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change user trip layout
add geocomplete library
geocomplete function done
Add expense to wishlist
unnested expenses from trips
Remove duplicate stylesheet links
Dashboard view
There was a problem hiding this comment.
If you make your current_user a helper method, you won't need to set it as an instance variable and pass it down to the view. You could then also just check for a current user on the view and if there is not one do what you need to do. (I.e whatever it is that you do when @is_wishlist is false.)
|
Have a look through the comments I have left in your code. The biggest thing I noticed was a need for refactoring controller logic into models (or helpers in some cases) and cleaning up your views to utilize partials more effectively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.