Skip to content
This repository has been archived by the owner on Jul 25, 2019. It is now read-only.

Add props which allow custom styling for button and "selected" button #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lionel-lints
Copy link
Contributor

This is a small PR to allow for custom styling to be added so css classes can overwrite the specific styles as needed. I am not sure this is the best solution, but the base case works for me. Happy to update anything upon request as well :-)

A developer could then add a buttonStyling prop and a pointStyling prop to the component which would overwrite any css as needed for both selected and unselected cases.

Added styling to adjust the css for the icon is not provided in this PR, I could potentially do it though in the future.

@lionel-lints
Copy link
Contributor Author

There seems to be a problem with my pointStyles, updating now...sorry!

@lionel-lints
Copy link
Contributor Author

OK updated, works for me now, sorry about that!

@mu29
Copy link
Owner

mu29 commented May 5, 2018

Hi. Thank you for your PR :)
However lib/index.js is transpiled code - i.e. you should edit index.jsx in root folder.

@lionel-lints
Copy link
Contributor Author

I see, ok I will take a look when I have some time and ping you back when I can update the PR
thanks :-)

@ads-pedroleao
Copy link

Hey, how's this going?

@lionel-lints
Copy link
Contributor Author

Sorry about the delay, things have been crazy for me, I will try to update this asap and get an updated PR in.

@xavierartot
Copy link

Hi,
I'm trying those properties, isn't working, no class are added in the html

        <RadioGroup  horizontal onChange={this.onChange}>
          <RadioButton iconSize={20} buttonStyling="primarytoto" pointStyling="test2"  value="optionOne">
            {optionOneText}
          </RadioButton>
          <RadioButton buttonStyling="test" iconSize={20} value="optionTwo">
            { optionTwoText }
          </RadioButton>
        </RadioGroup>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants