This repository has been archived by the owner on Jul 25, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Add props which allow custom styling for button and "selected" button #23
Open
lionel-lints
wants to merge
5
commits into
mu29:master
Choose a base branch
from
lionel-lints:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a problem with my pointStyles, updating now...sorry! |
OK updated, works for me now, sorry about that! |
Hi. Thank you for your PR :) |
I see, ok I will take a look when I have some time and ping you back when I can update the PR |
Hey, how's this going? |
Sorry about the delay, things have been crazy for me, I will try to update this asap and get an updated PR in. |
Hi,
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to allow for custom styling to be added so css classes can overwrite the specific styles as needed. I am not sure this is the best solution, but the base case works for me. Happy to update anything upon request as well :-)
A developer could then add a
buttonStyling
prop and apointStyling
prop to the component which would overwrite any css as needed for both selected and unselected cases.Added styling to adjust the css for the icon is not provided in this PR, I could potentially do it though in the future.