chore: log queries when failing #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes mu-semtech#22 As mentioned there in the current setup one would still have the sh parser trip over a use case like ``` export MODE="my mode" ./start.sh: line 4: [: too many arguments ```
This can result in double-logging queries (if the logging env vars are enabled) but this is in-line with how the mu-auth-sudo JS package does it.
…warning Fix typecheck for sparql_escape_float
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs queries when they result in an exception being thrown. Chatty services can then disable
LOG_SPARQL_ALLorLOG_SPARQL_{QUERIES,UPDATES}but still see queries that result in failures for some hopefully easier debugging.Note:
This can result in double-logging queries (if the logging env vars are enabled) but this is in-line with how the mu-auth-sudo JS package does it.
Currently available on Docker Hub as
sergiofenoll/mu-python-template:latest. Can be used while waiting for this to be merged, tagged and released, or while waiting for a feature branch to be released on this repo.