Status bar language not updated after change in user preference

[aroberge]

What were you trying to do?

Change the language for the UI

What steps did you take to trigger the issue?

• Changed the language
• Closed Mu and restarted
• Observed the message shown very briefly in the status bar

What did you expect to happen?

That the message would be shown in the newly selected language

What actually happened?

It was not:

Operating System Version

Windows 10

Mu Version

1.1.0.beta.6

Other Info

This was originally mentioned in a comment for issue #976

Editor Log

No response

[ntoll]

Just to confirm, you had changed to English 🇬🇧 from French 🇫🇷 but the message of the day was in French (when you were expecting it in English)..?

[aroberge]

@ntoll Correct: by default, Mu is in French on my system. After I changed to English and restarted, the menu was correctly changed to English but the message of the day (which I had never noticed before ... perhaps it is new?...) was not translated.

[devdanzin]

Confirmed. I think it comes from the fact the MOTD list is populated/localized before we do a i18n.set_language(self.user_locale). Then we pick a MOTD to display: self.show_status_message(random.choice(MOTD), 10)

It seems to be fixable by having a non-localized MOTD list, then localizing the selected entry:

-        self.show_status_message(random.choice(MOTD), 10)       
+        self.show_status_message(_(random.choice(MOTD)), 10)    

Working on a test and PR.

[devdanzin]

I have two different simple fixes ready for this issue and can't decide which one is better. Indeed, it comes from building MOTD before figuring out user_locale.

Option 1, it can be solved by localizing a single entry of the MOTD list after user_locale is set (as described in previous comment). It removes _() (gettext) from a lot of messages, I fear it might be detrimental for the localization workflow.

Option 2, we create a simple get_MOTD function so _() (gettext) remains in place but is only evaluated after user_locale is set.

Maybe I should just create two PRs and we can decide, with code to reference?

[xbecas]

Just to add that there are at least two other "places" where this happens:

The Modes Dialog and the comment on a blank file - both visible on the following image, where Portuguese sentences are shown with "English" explicitly chosen from language list.

PS: my W10 OS is in Portuguese.