fix: properly cleanup Windows process tree on Obsidian exit#33
Closed
Gerkinfeltser wants to merge 1 commit intomtymek:mainfrom
Closed
fix: properly cleanup Windows process tree on Obsidian exit#33Gerkinfeltser wants to merge 1 commit intomtymek:mainfrom
Gerkinfeltser wants to merge 1 commit intomtymek:mainfrom
Conversation
On Windows, when Obsidian closes with the OpenCode panel open, the server process (node.exe) becomes orphaned because: 1. shell: true spawns cmd.exe -> node.exe 2. The PID captured is cmd.exe, not the actual node.exe 3. Killing cmd.exe leaves node.exe running Changes: - WindowsProcess.stop(): Use PowerShell to find and kill child processes first - ServerManager: Added getPid() method - main.ts: Store serverPid separately for cleanup during window close - main.ts: Added killPidSync() with PowerShell child lookup (Windows) - main.ts: Added beforeunload handler for reliable cleanup on window close - main.ts: Updated onunload() to use sync cleanup with stored PID This ensures the actual node.exe process is killed when Obsidian closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, when Obsidian closes with the OpenCode panel open, the server process (node.exe) becomes orphaned because:
Solution
Store the PID separately in main.ts and use PowerShell to reliably find and kill child processes.
Changes
Testing
Tested on Windows 11: