Skip to content

Improvements on picture cache #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulienLevelUp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvements on picture cache #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16c5b39
Do not create a new RemoteImageLoaderImageViewAdapter if you want to …
JulienLevelUp Oct 17, 2012
1478d3b
If the view is reused do not download the bitmap
JulienLevelUp Oct 17, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...upport-lib/src/main/java/com/github/ignition/support/images/remote/RemoteImageLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,9 @@ public void loadImage(Drawable dummyDrawable, RemoteImageLoaderHandler handler)
if (imageCache != null && imageCache.containsKeyInMemory(imageUrl)) {
// do not go through message passing, handle directly instead
imageLoaderHandler.handleImageLoaded(imageCache.getBitmap(imageUrl), null);
} else {
executor.execute(new RemoteImageLoaderJob(imageUrl, imageLoaderHandler, imageCache,
numRetries, defaultBufferSize));
} else {
executor.execute(new RemoteImageLoaderJob(imageUrl, imageLoaderHandler, imageCache, numRetries, defaultBufferSize,
view));
}
}
}
5 changes: 5 additions & 0 deletions ...lib/src/main/java/com/github/ignition/support/images/remote/RemoteImageLoaderHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ public RemoteImageLoaderHandler(ImageView imageView, String imageUrl, Drawable e
init(imageView, imageUrl, errorDrawable);
}

public RemoteImageLoaderHandler(RemoteImageLoaderImageViewAdapter remoteImageLoaderImageViewAdapter) {
this.imageView = remoteImageLoaderImageViewAdapter.getView();
setRemoteImageLoaderViewAdapter(remoteImageLoaderImageViewAdapter);
}

public RemoteImageLoaderHandler(Looper looper, ImageView imageView, String imageUrl,
Drawable errorDrawable) {
super(looper);
Expand Down
4 changes: 4 additions & 0 deletions ...ort-lib/src/main/java/com/github/ignition/support/images/remote/RemoteImageLoaderJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ public void run() {
}

if (bitmap == null) {
// If the view is reused do not download the bitmap
if (reusableView != null & !imageUrl.equals(reusableView.getTag())) {
return;
}
bitmap = downloadImage();
}

Expand Down