Skip to content

Adding support for cookie store for IgnitedHttp #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leowhiterussian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding support for cookie store for IgnitedHttp #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...nition-support-lib/src/main/java/com/github/ignition/support/http/IgnitedHttpRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,10 @@ public interface IgnitedHttpRequest {
* Wi-Fi and 3G).
*/
public IgnitedHttpResponse send() throws ConnectException;

/**
* Sets the request to use the cookie store
*
*/
public IgnitedHttpResponse cookies();
}
14 changes: 14 additions & 0 deletions ...on-support-lib/src/main/java/com/github/ignition/support/http/IgnitedHttpRequestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
import org.apache.http.params.CoreConnectionPNames;
import org.apache.http.protocol.BasicHttpContext;
import org.apache.http.protocol.HttpContext;
import org.apache.http.client.protocol.ClientContext;
import org.apache.http.impl.client.BasicCookieStore;

import android.util.Log;

Expand All @@ -51,6 +53,8 @@ public abstract class IgnitedHttpRequestBase implements IgnitedHttpRequest,
protected HttpUriRequest request;

protected int maxRetries = MAX_RETRIES;

protected boolean useCookies = false;

private int oldSocketTimeout, oldConnTimeout;
private boolean timeoutChanged;
Expand Down Expand Up @@ -105,6 +109,11 @@ public IgnitedHttpRequest withTimeout(int timeout) {
return this;
}

@Override
public IgnitedHttpRequest cookies(boolean useCookies) {
this.useCookies = useCookies;
}

@Override
public IgnitedHttpResponse send() throws ConnectException {

Expand All @@ -115,6 +124,11 @@ public IgnitedHttpResponse send() throws ConnectException {

HttpContext context = new BasicHttpContext();

if (useCookies) {
BasicCookieStore cookieStore = new BasicCookieStore();
context.setAttribute(ClientContext.COOKIE_STORE, cookieStore);
}

// Grab a coffee now and lean back, I'm not good at explaining stuff. This code realizes
// a second retry layer on top of HttpClient. Rationale: HttpClient.execute sometimes craps
// out even *before* the HttpRequestRetryHandler set above is called, e.g. on a
Expand Down