Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 support #359

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

kajinamit
Copy link
Contributor

Python 3.7 already reached its EOL on 2023-06-27[1].

[1] https://devguide.python.org/versions/

Python 3.7 already reached its EOL on 2023-06-27[1].

[1] https://devguide.python.org/versions/
Copy link
Owner

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we tend to support a python version past the eol date a bit so people can still test code as they migrate to a newer version. But I agree it's been long enough now. Thanks for doing this.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc66736) 61.95% compared to head (642f130) 61.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   61.95%   61.95%           
=======================================
  Files          30       30           
  Lines        2618     2618           
  Branches      426      426           
=======================================
  Hits         1622     1622           
  Misses        877      877           
  Partials      119      119           
Flag Coverage Δ
unittests 61.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtreinish mtreinish merged commit 3862766 into mtreinish:main Feb 7, 2024
20 checks passed
@kajinamit kajinamit deleted the remove-py37 branch February 8, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants