Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async swaps on install #7841

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Oct 24, 2024

Added a unit test for yagi-uda, just relied on tests not breaking for daruma/midori.

Closes #7839

@NoahTheDuke
Copy link
Collaborator

Is there ever a time we wouldn't want to async swap cards?

@NBKelly
Copy link
Collaborator Author

NBKelly commented Oct 24, 2024

If neither or both of them are installed, there aren't any events that matter (at least for now).
Sooner or later I'll see about making all movement async.

@NoahTheDuke
Copy link
Collaborator

making all movement async would be... one hell of a pr. i've resisted it for years lol. the better move imo would be to change the engine to work on steps of some form and stop relying on callbacks (aka async). but that's also a lot of work... ;_;

@NoahTheDuke NoahTheDuke merged commit 1e722a9 into mtgred:master Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Yagi-Uda should use the Async swap
2 participants