Skip to content

feat(json-schema): use TypeInfo's Type #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mtarld
Copy link
Owner

@mtarld mtarld commented Feb 24, 2025

No description provided.

@coveralls
Copy link

coveralls commented Feb 24, 2025

Pull Request Test Coverage Report for Build 13498321015

Details

  • 63 of 82 (76.83%) changed or added relevant lines in 4 files are covered.
  • 2472 unchanged lines in 162 files lost coverage.
  • Overall coverage remained the same at 8.563%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/JsonSchema/Metadata/Property/Factory/SchemaPropertyMetadataFactory.php 35 37 94.59%
src/JsonSchema/SchemaFactory.php 28 30 93.33%
src/JsonSchema/Tests/Metadata/Property/Factory/SchemaPropertyMetadataFactoryTest.php 0 4 0.0%
src/JsonSchema/Tests/SchemaFactoryTest.php 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
src/Doctrine/Orm/Filter/AbstractFilter.php 1 90.0%
src/GraphQl/Error/ErrorHandler.php 1 0.0%
src/GraphQl/Resolver/ResourceFieldResolver.php 1 81.82%
src/GraphQl/Resolver/Util/IdentifierTrait.php 1 28.57%
src/GraphQl/Type/TypeNotFoundException.php 1 0.0%
src/GraphQl/Type/TypesContainer.php 1 66.67%
src/Hal/JsonSchema/SchemaFactory.php 1 95.83%
src/Hydra/JsonSchema/SchemaFactory.php 1 96.94%
src/Hydra/Serializer/CollectionNormalizer.php 1 92.0%
src/Hydra/Serializer/EntrypointNormalizer.php 1 95.24%
Totals Coverage Status
Change from base Build 13472011848: 0.0%
Covered Lines: 13465
Relevant Lines: 157240

💛 - Coveralls

@mtarld mtarld force-pushed the chore/type-info-type-json-schema branch from 9cdccf4 to 780a37d Compare February 24, 2025 12:43
@mtarld mtarld force-pushed the chore/type-info-type-metadata branch 7 times, most recently from 4b6eaa7 to b4ae0b4 Compare February 28, 2025 10:58
@soyuka soyuka force-pushed the chore/type-info-type-metadata branch 5 times, most recently from 1be8f2f to a41e8de Compare April 15, 2025 12:54
soyuka added a commit that referenced this pull request Apr 16, 2025
@soyuka soyuka force-pushed the chore/type-info-type-metadata branch from eaac4cd to 2dedf58 Compare April 16, 2025 08:06
@soyuka
Copy link
Collaborator

soyuka commented Apr 16, 2025

thanks I've added this work manually as I wanted to keep a bc layer, this one can be closed

@soyuka soyuka force-pushed the chore/type-info-type-metadata branch 3 times, most recently from 55956f7 to bbbae81 Compare April 16, 2025 13:40
soyuka added a commit that referenced this pull request Apr 16, 2025
@mtarld mtarld closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants