[BOB-380] Add IValidateable interface #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct typos, grammar, examples, formatting - Reword for clarity - Add more clarity to some sections
devinlyons
reviewed
Jul 20, 2023
| Username: string option | ||
| Password: string option } | ||
| interface IValidateable<NewUserFailures> with |
Contributor
There was a problem hiding this comment.
I don't understand the point of the interface. What's it for?
devinlyons
reviewed
Jul 20, 2023
| type NewUserVM = | ||
| // ... nothing new here | ||
| interface IModelValidation<NewUserVM> with |
Contributor
There was a problem hiding this comment.
This implementation suggests validation without transformation. That's antithetical to the design of this library.
devinlyons
reviewed
Jul 21, 2023
| match | ||
| // To access Validate() on the IValidateable<NewUserFailures> interface, | ||
| // we must upcast to that interface. | ||
| (this :> IValidateable<NewUserFailures>).Validate() |
Contributor
There was a problem hiding this comment.
The IValidatable method doesn't really do anything here that a simple function call couldn't handle.
Contributor
Author
|
Closing this PR in favor of a separate Giraffe model validation interface #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: It will be easier to review this PR by stepping through each commit.
IValidateable<'F>interface type and documentation (second commit)IValidateableinterface in concert with Giraffe model validation (third commit)