Add utility functions to help with using NonEmptyLists [MBI-53] #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinlyons
approved these changes
Feb 28, 2022
wduncanfraser
approved these changes
Mar 4, 2022
Contributor
There was a problem hiding this comment.
Overall this looks good. I didn't go through and compare every name, but I'd say the one thing is we want to make sure overlapping functions are named the same as their FSharp List counterparts, for consistency in the ecosystem. https://fsharp.github.io/fsharp-core-docs/reference/fsharp-collections-listmodule.html
Anything outside that can be named whatever. But yeah, if we are consistent on that front, good to go.
Contributor
Author
|
Updated the following per your comment: |
mleone11
force-pushed
the
fsdv-nonemptylist-utils
branch
from
a5cd441 to
394e2c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if there is a function you were hoping for that I missed, or one that you don't think we'll need
Also keep in mind that the naming conventions might lean more functional (based on Haskell) and I'm open to making them more like .NET. I kept that in mind when I wrote this draft but might have overlooked some.