Clear existing/conflicting dye recipes #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
where are the existing recipes coming from in the first place? 🤔 |
Contributor
Author
|
These recipes are registered by the dye mod of Minetest Game: |
Contributor
|
should if be gated for mtg then |
Contributor
Author
IMHO, it makes sense to clear these recipes unconditionally as nobody benefits from conflicting recipes and clearing recipes that are not registered doesn't do any harm. Since unifieddyes provides a comprehensive color mixing system, I think it is also safe to remove color mixing recipes that any base game has registered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears existing, conflicting recipes first before registering the new recipes for the base colors and shades.
Should fix #12.
Should fix #14.