Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llama.cpp #19525

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Conversation

Kreijstal
Copy link
Contributor

also adding mingw64 as target

@MehdiChinoune
Copy link
Collaborator

MehdiChinoune commented Dec 23, 2023

Please, remove mingw64, update pkgver properly and use a better commit message.

@Kreijstal
Copy link
Contributor Author

Please, remove mingw64, update pkgver properly and use a better commit message.

It compiles using mingw64, and it runs, what's the problem?

@MehdiChinoune
Copy link
Collaborator

Please, remove mingw64, update pkgver properly and use a better commit message.

It compiles using mingw64, and it runs, what's the problem?

We are pushing people to use UCRT64, because at certain time MINGW64 will be dropped (in the far future).

@Kreijstal
Copy link
Contributor Author

Kreijstal commented Dec 23, 2023

Please, remove mingw64, update pkgver properly and use a better commit message.

It compiles using mingw64, and it runs, what's the problem?

We are pushing people to use UCRT64, because at certain time MINGW64 will be dropped (in the far future).

The reason why mingw64 was not supported on this package, was because upstream didn't support it, since upstream didn't support it, it didn't make sense but since upstream supports it now , why wouldn't you support mingw64 if you can?, makes no sense to me, like lazka@2dc9224 , anyway, the version is based on the tag on the github repository, what would be the right version, anyway?

@MehdiChinoune
Copy link
Collaborator

Please, Fix pkgver.
Just change the commit and makepkg-mingw will fix it for you.

@Kreijstal
Copy link
Contributor Author

Please, Fix pkgver. Just change the commit and makepkg-mingw will fix it for you.

I will, just tell me what should pkgver should be...? I am getting it from the github repo...

@MehdiChinoune
Copy link
Collaborator

Please, Fix pkgver. Just change the commit and makepkg-mingw will fix it for you.

I will, just tell me what should pkgver should be...? I am getting it from the github repo...

I said, just run makepkg-mingw and it will update it for you.

@lazka lazka merged commit ea3dce6 into msys2:master Dec 23, 2023
8 checks passed
@Kreijstal Kreijstal deleted the Kreijstal-patch-3 branch December 23, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants