Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ca-certificates: Fix installation destination for certificates #15143

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

MehdiChinoune
Copy link
Collaborator

No description provided.

@MehdiChinoune MehdiChinoune merged commit 68419ae into msys2:master Jan 17, 2023
@MehdiChinoune MehdiChinoune deleted the ca-certificates-rebuild branch January 17, 2023 18:51
@MSP-Greg
Copy link
Contributor

Please consider placing the files in both ssl and etc/ssl. As stated elsewhere, OpenSSL 1.1.1 is EOL in September of this year...

@dscho
Copy link
Contributor

dscho commented Jan 18, 2023

Hmm. This broke Git for Windows. And neither the commit message nor the PR description even so much as attempts to do an adequate job of explaining what on Earth is going on that this needed to change.

I had to follow some random references to figure out that this change is because Arch does it this way. Well, given that RubyInstaller and Git for Windows got broken by this, it looks to me as if that was not a very strong justification for that change.

dscho added a commit to dscho/MINGW-packages that referenced this pull request Jan 18, 2023
As per msys2#15143, MSYS2 moved
the `ca-bundle.crt` file from `$MINGW_PREFIX/ssl/certs/` to
`$MINGW_PREFIX/etc/ssl/certs/`, nominally to align MSYS2 more with Arch
Linux
(msys2@2f97826e8a8f#r96397884).

This requires a lot of reactive work, and this here patch is one of
them.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to git-for-windows/git-sdk-64 that referenced this pull request Jan 21, 2023
It was moved recently:
msys2/MINGW-packages#15143

This is yet another fall-out.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to git-for-windows/git-sdk-64 that referenced this pull request Jan 21, 2023
It was moved recently:
msys2/MINGW-packages#15143

This is yet another fall-out.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
ammyk9 pushed a commit to ammyk9/MINGW-packages that referenced this pull request Aug 8, 2024
As per msys2#15143, MSYS2 moved
the `ca-bundle.crt` file from `$MINGW_PREFIX/ssl/certs/` to
`$MINGW_PREFIX/etc/ssl/certs/`, nominally to align MSYS2 more with Arch
Linux
(msys2@2f97826e8a8f#r96397884).

This requires a lot of reactive work, and this here patch is one of
them.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to git-for-windows/git-sdk-arm64 that referenced this pull request Aug 13, 2024
It was moved recently:
msys2/MINGW-packages#15143

This is yet another fall-out.

Ported-from-git-sdk-64: c1be5c8 (minimal: (re-)include the `ca-bundle.crt` file, 2023-01-21)
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to git-for-windows/git-sdk-arm64 that referenced this pull request Aug 13, 2024
It was moved recently:
msys2/MINGW-packages#15143

This is yet another fall-out.

Ported-from-git-sdk-64: c1be5c8 (minimal: (re-)include the `ca-bundle.crt` file, 2023-01-21)
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants