Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): clone request before parsing #1714

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

kettanaito
Copy link
Member

  • Fixes an issue that caused Error: cannot clone body after it is used error to be thrown after GraphQL request parsing. Ensures MSW doesn't lock the body stream during parsing for any downstream consumers.

This was discovered during MSW 2.0 + Remix 2.0 testing.

@kettanaito kettanaito force-pushed the fix/clone-request-before-gql-parsing branch from 7daeee4 to 1275e0c Compare August 25, 2023 10:55
@kettanaito kettanaito merged commit 3b8f57e into feat/standard-api Aug 25, 2023
11 checks passed
@kettanaito kettanaito deleted the fix/clone-request-before-gql-parsing branch August 25, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant