fix(XMLHttpRequest): support request upload events
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
fix/xhr-upload-progress
branch
from
bed807b
to
98336a1
Compare
kettanaito
force-pushed
the
fix/xhr-upload-progress
branch
from
dbce934
to
12d0213
Compare
Released: v0.34.2 🎉This has been released in v0.34.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Upload events are not implemented in JSDOM (
totalis always0). This, as all the other XHR functionality, must be tested in the actual browser.Roadmap
uploadcallbacks (onprogress, etc).URLSearchParams, etc). Ideally, cover every possible request body type (mostly to assert the right body length intotal).