feat: support relative paths when generating rest handlers #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkolotov
force-pushed
the
feat/rest-handlers-relative-paths
branch
2 times, most recently
from
12469b7
to
0695b58
Compare
kettanaito
approved these changes
Mar 6, 2023
|
@kettanaito Something seems to be very wrong with the CI. I don't know much about CI in GitHub, but perhaps |
|
Yeah, the issue seems to be not related to your changes. I will look into that. |
|
@kettanaito anything here? |
|
@kettanaito fixed it, I guess #270 (still can't request the review) |
|
Thanks for fixing that, @timkolotov. Could you please rebase this branch? The CI issue should be gone then. |
timkolotov
force-pushed
the
feat/rest-handlers-relative-paths
branch
from
0695b58
to
0179761
Compare
|
Seems all good now 😃 |
Released: v0.12.0 🎉This has been released in v0.12.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of URL constructor in
createUrlBuilderwhich is used for generating REST handlers.Approach with strings concatenation allows us to use relative paths without specific hostnames, provide prefixes, and also use parameters in the baseUrl that will be handled by MSW.
I also added removing trailing slashes from the baseUrl, as previously it could be passed with and without it and won't affect the result, so I keep it like it was to avoid breaking changes.
Additionally updated tests for the function: removed the leading slash. Because
buildUrlcalls insidegenerateRestHandlershave no leading shashes so tests weren't exactly correct.(ref: #267)