Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make "EntityType" type compatible with objects #251

Merged
merged 2 commits into from
Jan 24, 2023
Merged

fix: make "EntityType" type compatible with objects #251

merged 2 commits into from
Jan 24, 2023

Conversation

imyasha
Copy link
Contributor

@imyasha imyasha commented Nov 17, 2022 •
edited by kettanaito
Loading

Fixes #250

@kettanaito kettanaito changed the title FIX: fix 'EntityType' does not satisfy the constraint 'AnyObject' error fix: make "EntityType" type compatible with objects Nov 20, 2022
kettanaito
kettanaito requested changes Nov 20, 2022
View reviewed changes
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @imyasha 👋 Thanks for opening this.

Looks like the build is failing. I suspect that the AnyObject type is not publicly exported by the library (it's internal) and thus certain types cannot compile?

If you have a minute, could you take a look at what's going on? Thanks.

@imyasha
Copy link
Contributor Author

imyasha commented Nov 22, 2022

Hey, @kettanaito
I was trying to export AnyObject but it doesn't solve the build error.
I think it's related with other thing.

Please take a look at it if you can.
Thanks

@kettanaito @cre8ive-gds
fix(queryTypes): remove "extend" in "infer"
d80dcf2 
Co-authored-by: Gagan Deep Singh <gagandeep.singh1@rackspace.com>
kettanaito
kettanaito approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @cre8ive-gds additions this looks good now! Thank you!

@kettanaito kettanaito merged commit 06e233e into mswjs:main Jan 24, 2023
@kettanaito
Copy link
Member

Released: v0.11.2 🎉

This has been released in v0.11.2!

Make sure to always update to the latest version (npm i @mswjs/data@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ive-gds cre8ive-gds cre8ive-gds left review comments

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type Error on queryTypes.ts file.
3 participants
@imyasha @kettanaito @cre8ive-gds