windres-wrapper does not support macros in strings

[driver1998]

Test file

#include <windows.h>

#define WORLD "world"

STRINGTABLE DISCARDABLE
BEGIN
    2048 "Hello " WORLD
END

Result

$ i686-w64-mingw32-windres -i test.rc -o test.res
llvm-rc: Error parsing file: expected '-', '~', integer or '(', got "world"
i686-w64-mingw32-windres: error: llvm-rc failed

[Biswa96]

Agreed. For example, I have tried to compile 86Box and llvm-rc shows that error. Maybe this is a llvm bug/absent feature.

[mstorsjo]

Thanks for the reduced testcase!

This is not a bug with macros themselves, but with concatenation. If you remove the space between "Hello" and WORLD, it builds fine.

So the testcase can be reduced into

STRINGTABLE DISCARDABLE
BEGIN
    2048 "Hello" "world"
END

This is a bit tricky, as 2048 and the rest should be considered separate args (you can have an optional comma inbetween), while "Hello" and "world" aren't two separate arguments but should be concatenated into one string.

[mstorsjo]

This is not a bug with macros themselves, but with concatenation. If you remove the space between "Hello" and WORLD, it builds fine.

Actually, it might build fine in that case, but it actually ends up different/wrong in that case. That expands to "Hello""world", which gets unescaped into Hello"world, which isn't what was expected.

[mstorsjo]

I posted a patch that should fix this issue at https://reviews.llvm.org/D85183.