Merge pull request #416 from Rawk/win-stop-on-err

mstange · web-flow · commit 36646f148ad1 · 2024-11-16T19:50:56.000+01:00
Skip remaining iterations on Windows too
diff --git a/samply/src/windows/profiler.rs b/samply/src/windows/profiler.rs
@@ -110,7 +110,11 @@ pub fn start_recording(
                 // give us a chance to stop xperf.
                 let exit_status = child.wait().unwrap();
                 if !exit_status.success() {
-                    eprintln!("Child process exited with {:?}", exit_status);
+                    eprintln!(
+                        "Skipping remaining iterations due to non-success exit status: \"{}\"",
+                        exit_status
+                    );
+                    break;
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,11 @@ pub fn start_recording(`
`110`	`110`	`// give us a chance to stop xperf.`
`111`	`111`	`let exit_status = child.wait().unwrap();`
`112`	`112`	`if !exit_status.success() {`
`113`		`- eprintln!("Child process exited with {:?}", exit_status);`
	`113`	`+ eprintln!(`
	`114`	`+ "Skipping remaining iterations due to non-success exit status: \"{}\"",`
	`115`	`+ exit_status`
	`116`	`+ );`
	`117`	`+ break;`
`114`	`118`	`}`
`115`	`119`	`}`
`116`	`120`