Merge pull request #415 from jrmuizel/better-errors

mstange · web-flow · commit bd79123a10fa · 2024-11-14T15:47:32.000+01:00
Make the Unknown property error more useful
diff --git a/etw-reader/src/parser.rs b/etw-reader/src/parser.rs
@@ -234,7 +234,7 @@ impl<'a> Parser<'a> {
             .properties
             .name_to_indx
             .get(name)
-            .ok_or_else(|| ParserError::PropertyError("Unknown property".to_owned()))?;
+            .ok_or_else(|| ParserError::PropertyError(format!("Unknown property: {}", name)))?;
         if indx < self.cache.len() {
             return Ok(indx);
         }

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ impl<'a> Parser<'a> {`
`234`	`234`	`.properties`
`235`	`235`	`.name_to_indx`
`236`	`236`	`.get(name)`
`237`		`- .ok_or_else(\|\| ParserError::PropertyError("Unknown property".to_owned()))?;`
	`237`	`+ .ok_or_else(\|\| ParserError::PropertyError(format!("Unknown property: {}", name)))?;`
`238`	`238`	`if indx < self.cache.len() {`
`239`	`239`	`return Ok(indx);`
`240`	`240`	`}`