Skip to content

✨ feat: support config provider support aws appconfig #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lwnmengjing merged 1 commit into from
Jul 18, 2024
Merged

✨ feat: support config provider support aws appconfig #123

lwnmengjing merged 1 commit into from
Jul 18, 2024

Conversation

@lwnmengjing
Copy link
Member

@lwnmengjing lwnmengjing commented Jul 18, 2024 •
edited
Loading

Description

#122

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (main)
  • no unintentional fmt.Print left behind after debugging
  • did I name variables, methods and classes according to the naming rules? (https://go.dev/doc/effective_go#names)
  • caught exceptions or throw them to the upper level for processing, not ignored (https://go.dev/doc/effective_go#errors)
  • did I explain all possible solutions and why I chose the one I did?
  • added any comments to make new functions clearer
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors
  • instructions for how reviewers can test the code locally
  • screenshot of the feature/bug fix (if applicable)

@lwnmengjing lwnmengjing requested a review from mss-boot July 18, 2024 13:05
@lwnmengjing lwnmengjing self-assigned this Jul 18, 2024
@lwnmengjing lwnmengjing added the enhancement New feature or request label Jul 18, 2024
@lwnmengjing lwnmengjing merged commit 02bcef7 into main Jul 18, 2024
@lwnmengjing lwnmengjing deleted the feat/support-aws-appconfig branch July 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mss-boot mss-boot mss-boot approved these changes

Assignees

@lwnmengjing lwnmengjing

Labels

enhancement New feature or request

Projects

mss-boot-admin
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lwnmengjing @mss-boot