fix: Set DialogContainerRenderable visibility based on dialog count#17
Merged
msmps merged 2 commits intomsmps:mainfrom Jan 6, 2026
Merged
Conversation
The container was intercepting all mouse events (scroll, click) even when no dialogs were displayed because it never set `visible = false`. Changes: - Set `this.visible = false` in constructor - Update `this.visible` in `updateBackdropVisibility()` alongside backdrop Fixes: ainergiz/xfeed#204 Repro: https://github.com/ainergiz/xfeed/tree/repro/dialog-hit-grid-bug
…ntainerRenderable Updated the DialogContainerRenderable to have a transparent background and set its initial visibility to false. This change ensures that the container does not intercept mouse events when no dialogs are displayed. Changes: - Added `backgroundColor: "transparent"` to the container style - Set `visible: false` in the constructor This complements the previous fix for visibility management based on dialog count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container was intercepting all mouse events (scroll, click) even when no dialogs were displayed because it never set
visible = false.Changes:
this.visible = falsein constructorthis.visibleinupdateBackdropVisibility()alongside backdropHopefully fixes: 16[https://github.com//issues/16]