forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 126
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/…
…mmarek/kbuild Pull kbuild misc changes from Michal Marek: "In the non-critical part of kbuild, I have - Some make coccicheck improvements and two new tests - Support for a cleaner html output in scripts/kernel-doc, named html5 (no, it does not play videos, yet) BTW, Randy wants to route further kernel-doc patches through the kbuild tree." * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild: Update SmPL/Coccinelle section of MAINTAINERS coccicheck: Add the rep+ctxt mode scripts/coccinelle/tests/odd_ptr_err.cocci: semantic patch for IS_ERR/PTR_ERR inconsistency scripts/tags.sh: Add magic for pci access functions scripts/coccinelle: ptr_ret: Add ternary operator version scripts/kernel-doc: drop maintainer scripts/kernel-doc: added support for html5
- Loading branch information
Showing
6 changed files
with
369 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/// PTR_ERR should access the value just tested by IS_ERR | ||
//# There can be false positives in the patch case, where it is the call | ||
//# IS_ERR that is wrong. | ||
/// | ||
// Confidence: High | ||
// Copyright: (C) 2012 Julia Lawall, INRIA. GPLv2. | ||
// Copyright: (C) 2012 Gilles Muller, INRIA. GPLv2. | ||
// URL: http://coccinelle.lip6.fr/ | ||
// Comments: | ||
// Options: -no_includes -include_headers | ||
|
||
virtual patch | ||
virtual context | ||
virtual org | ||
virtual report | ||
|
||
@depends on patch@ | ||
expression e,e1; | ||
@@ | ||
|
||
( | ||
if (IS_ERR(e)) { ... PTR_ERR(e) ... } | ||
| | ||
if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... } | ||
| | ||
if (IS_ERR(e)) | ||
{ ... | ||
PTR_ERR( | ||
- e1 | ||
+ e | ||
) | ||
... } | ||
) | ||
|
||
@r depends on !patch@ | ||
expression e,e1; | ||
position p1,p2; | ||
@@ | ||
|
||
( | ||
if (IS_ERR(e)) { ... PTR_ERR(e) ... } | ||
| | ||
if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... } | ||
| | ||
*if (IS_ERR@p1(e)) | ||
{ ... | ||
* PTR_ERR@p2(e1) | ||
... } | ||
) | ||
|
||
@script:python depends on org@ | ||
p1 << r.p1; | ||
p2 << r.p2; | ||
@@ | ||
cocci.print_main("inconsistent IS_ERR and PTR_ERR",p1) | ||
cocci.print_secs("PTR_ERR",p2) | ||
@script:python depends on report@ | ||
p1 << r.p1; | ||
p2 << r.p2; | ||
@@ | ||
msg = "inconsistent IS_ERR and PTR_ERR, PTR_ERR on line %s" % (p2[0].line) | ||
coccilib.report.print_report(p1[0],msg) |
Oops, something went wrong.