Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit MIPI DSI Picture Parameter Set command #46

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarijnS95
Copy link
Contributor

@MarijnS95 MarijnS95 commented May 16, 2024

Draft. This is not something I think we should actually send, since the PPS send command is already emitted if qcom,compression-mode = <DSC>;. However, if the PPS is present in device DTSI, I do want to make the user aware that it exists and give them a way to compare it with whatever the automated mipi_dsi_picture_parameter_set() sends.

Note that this PPS is built up partially by the panel driver, and then further filled in by drm/msm drivers and DRM DSC helpers. Hence differences might sometimes be key in debugging a DSC setup.

For now the PPS could be emitted to the kernel log with the following snippet, but before going ahead and emitting a print for both, does anyone know of a proper way to diff or compare and print the result instead?

print_hex_dump(KERN_INFO, "DSC:", DUMP_PREFIX_NONE, 16,
               1, (void *)&pps, sizeof(pps), false);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant