Emit MIPI DSI Picture Parameter Set command #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft. This is not something I think we should actually send, since the PPS send command is already emitted if
qcom,compression-mode = <DSC>;
. However, if the PPS is present in device DTSI, I do want to make the user aware that it exists and give them a way to compare it with whatever the automatedmipi_dsi_picture_parameter_set()
sends.Note that this PPS is built up partially by the panel driver, and then further filled in by
drm/msm
drivers and DRM DSC helpers. Hence differences might sometimes be key in debugging a DSC setup.For now the PPS could be emitted to the kernel log with the following snippet, but before going ahead and emitting a print for both, does anyone know of a proper way to diff or compare and print the result instead?