fix: prevent FileNotFoundError when storages.touch() is called with a…#619
Open
n1teshy wants to merge 1 commit into
Open
fix: prevent FileNotFoundError when storages.touch() is called with a…#619n1teshy wants to merge 1 commit into
n1teshy wants to merge 1 commit into
Conversation
… file in current directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, the
touchfunction in storages.py callsos.makedirsifcreate_dirsisTrue, but a user may unknowingly passcreate_dirsas True even when the JSON file to be created is in the current working directory, in which case, the file's directory would be an empty string andFileNotFoundErrorwould be raised byos.makedirs.Traceback (most recent call last):
File "", line 1, in
TinyDB('some.json', create_dirs=True)
~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/nitesh/Desktop/programming/open-source/tinydb/tinydb/database.py", line 95, in init
self._storage: Storage = storage(*args, **kwargs)
~~~~~~~^^^^^^^^^^^^^^^^^
File "/home/nitesh/Desktop/programming/open-source/tinydb/tinydb/storages.py", line 117, in init
touch(path, create_dirs=create_dirs)
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/nitesh/Desktop/programming/open-source/tinydb/tinydb/storages.py", line 28, in touch
os.makedirs(base_dir)
~~~~~~~~~~~^^^^^^^^^^
File "", line 236, in makedirs
FileNotFoundError: [Errno 2] No such file or directory: ''