Remove absolute imports to support vendoring #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiemens
reviewed
Jun 22, 2017
tinydb/__init__.py
Outdated
| >>> from tinydb import TinyDB, where | ||
| >>> from tinydb.storages import MemoryStorage | ||
| >>> from . import TinyDB, where | ||
| >>> from .storages import MemoryStorage |
There was a problem hiding this comment.
I think we should keep the absolute import here as that's what users will usually continue to use. Or am I mistaken?
There was a problem hiding this comment.
Oh, yes you are right. Sorry about that.
|
One small nit with the docstring, otherwise looks good to me! |
|
Merged, thanks! I'll try to find to release a new version of TinyDB next week :) |
|
BTW, I've just released v3.3.1 which includes this pull request :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
Thanks for this amazing project! I'm looking to bundle tinydb with another software library but couldn't due to the global references to
tinydbin import statements.This PR makes all imports relative, so that you can now do this.
Let me know if there are any issues.