- 
                Notifications
    You must be signed in to change notification settings 
- Fork 234
ci: add support for building windows on arm wheels #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1d94f77
              
                ci: add support for building windows on arm wheels
              
              
                Greenie0701 d53ad27
              
                Enable test suite for Windows on ARM
              
              
                Greenie0701 a05524e
              
                ci: add support for building windows arm wheels
              
              
                Greenie0701 e6a5315
              
                ci: add support for building and testing win arm64 wheels
              
              
                Greenie0701 2d13370
              
                ci: add support for building and testing woa wheels
              
              
                Greenie0701 29a57a1
              
                ci: add support for building and testing windows arm wheels
              
              
                Greenie0701 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want add them into
wheel.yml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@methane, yeah I have missed that out. Thanks for pointing out
The reason I have excluded those builds is that Official Python distribution for Windows ARM64 starts from 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look again at the diff of the two files being edited in this PR.
You are adding windows-11-arm to excludes, while window-11-arm is not included in the matrix of this file.
You probably forgot to add windows-11-arm to the matrix of this file, or you intended to add excludes to the other file, not this one.